-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and future-proof enum range checks in door locks. #24879
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:door-lock-enum-checks
Feb 8, 2023
Merged
Simplify and future-proof enum range checks in door locks. #24879
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:door-lock-enum-checks
Feb 8, 2023
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt and
mspang
February 6, 2023 18:24
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 6, 2023 18:24
bzbarsky-apple
force-pushed
the
door-lock-enum-checks
branch
from
February 6, 2023 18:36
c7b48b0
to
af27aae
Compare
bzbarsky-apple
changed the title
Simplfy and future-proof enum range checks in door locks.
Simplify and future-proof enum range checks in door locks.
Feb 6, 2023
PR #24879: Size comparison from 3d09d2d to af27aae Increases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Decreases (15 builds for cc13x2_26x2, cyw30739, efr32, esp32, mbed, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Feb 6, 2023
andy31415
approved these changes
Feb 6, 2023
Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936
bzbarsky-apple
force-pushed
the
door-lock-enum-checks
branch
from
February 6, 2023 22:57
26e556c
to
2d8aa7d
Compare
PR #24879: Size comparison from 5eb5d91 to 2d8aa7d Increases above 0.2%:
Increases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, esp32, mbed, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Feb 8, 2023
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Feb 13, 2023
…hip#24879) * Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936 * Address review commment. * Address more review comments.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…hip#24879) * Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936 * Address review commment. * Address more review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range.
Fixes #20936